Skip to content

Fixed InputAction.cs #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelsakharov merged 1 commit into from
Oct 12, 2025
Merged

Fixed InputAction.cs #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions Prowl.Runtime/InputManagement/InputAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,6 @@ internal void UpdateState(IInputHandler inputHandler, double currentTime)
// Read the current value from bindings with interaction logic
object newValue = ReadValueFromBindings(inputHandler, currentTime);

// Apply processors
newValue = ApplyProcessors(newValue);

bool valueChanged = !newValue.Equals(_currentValue);
_currentValue = newValue;

Expand Down Expand Up @@ -278,7 +275,17 @@ private object ReadValueFromBindings(IInputHandler inputHandler, double currentT
{
object compositeValue = composite.ReadValue(inputHandler);
if (IsValueActuated(compositeValue))
{
// Apply processors from the composite
foreach (var processor in composite.Processors)
{
if (compositeValue is float floatValue)
compositeValue = processor.Process(floatValue);
else if (compositeValue is Float2 vectorValue)
compositeValue = processor.Process(vectorValue);
}
return compositeValue;
}
}

// Then check regular bindings with interaction logic
Expand All @@ -289,6 +296,16 @@ private object ReadValueFromBindings(IInputHandler inputHandler, double currentT
_interactionStates[binding] = new InteractionState();

object rawValue = ReadBinding(binding, inputHandler);

// Apply processors from THIS binding only
foreach (var processor in binding.Processors)
{
if (rawValue is float floatValue)
rawValue = processor.Process(floatValue);
else if (rawValue is Float2 vectorValue)
rawValue = processor.Process(vectorValue);
}

bool isActuated = IsValueActuated(rawValue);

// Evaluate interaction and get the result
Expand Down Expand Up @@ -485,17 +502,8 @@ private object ReadBinding(InputBinding binding, IInputHandler inputHandler)

private object ApplyProcessors(object value)
{
foreach (var binding in Bindings)
{
foreach (var processor in binding.Processors)
{
if (value is float floatValue)
value = processor.Process(floatValue);
else if (value is Float2 vectorValue)
value = processor.Process(vectorValue);
}
}

// Don't apply processors from all bindings - this is handled per-binding
// Processors should be applied in ReadValueFromBindings instead
return value;
}

Expand Down
Loading