Change DLLImport to newer LibraryImport for miniaudio #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tryibion
changed the title
Contributor
|
Woops, didnt mean to press that. Are you looking to have this reviewed/merged now? Or is this still a draft? |
Contributor
Author
|
It can be reviewed and merged. The only caveat is if you notice some of the callbacks are not working they will just need to be changed as I only changed the initialize one since that was the only one the audio demo seemed to be using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the newer library import instead of the dllimport for the miniaudio library.
I did not convert all of the callbacks because those are handled differently using LibraryImport where they use a delegate pointer, but this is a decent start and the audio demo still works.