Refactored CalcECC function to simplify calls.#440
Open
Yayformee wants to merge 4 commits intoPseudo-Corp:masterfrom
Open
Refactored CalcECC function to simplify calls.#440Yayformee wants to merge 4 commits intoPseudo-Corp:masterfrom
Yayformee wants to merge 4 commits intoPseudo-Corp:masterfrom
Conversation
Changed the parameters from (type, #completions) to (index). This can be done since both the type and the #completions strictly depend on the challenge index.
KhafraDev
approved these changes
Jan 27, 2023
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
Thanks for the PR! We're currently working on other things so this PR will probably be delayed a little longer.
KhafraDev
requested changes
May 13, 2023
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
I'm sorry but I've changed my mind. It does simplify it, but I think it's too much if that makes sense. I like that it has to be explicitly called with a type; I'd rather keep it that way. Of course a change where moving player.challengecompletions[index]s could be moved to CalcECC in a way that still simplifies the code while still making the function explicit.
Contributor
Author
|
Completed changes as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the parameters from (type, #completions) to (index).
This can be done since both the type and the #completions strictly depend on the challenge index.