add VLLM to nix packages :) #464
Merged
+223
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arilotter
force-pushed
the
vlllm
branch
5 times, most recently
from
6a0cfa3 to
c1d3801
Compare
fixes some cuda lib path problems in vllm updates mdbook fixes some clippy lints later, we should consider splitting the vllm code into a separate set of deps, so the regular psyche binaries don't get vllm included
Collaborator
Author
|
all inference tests seem to pass under vllm! $ nix develop .#dev-python --command "cargo test -p psyche-inference --features vllm-tests"passed :) @samherring99 anything else to do here? are these tests run under CI somehow? |
Collaborator
|
LGTM! the tests are run in CI without the |
arilotter
added a commit
that referenced
this pull request
Jan 11, 2026
This reverts commit b8e1464.
arilotter
added a commit
that referenced
this pull request
Jan 11, 2026
Reverts #464 failure with `Cannot load symbol cudnnGetVersion` on CUDA gpu after loading model :( ``` nix develop just setup-localnet-light-test-run just start-training-localnet-light-client ``` on an h100 machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required a bunch of upstream changes in nixpkgs :)
closes #470