Skip to content

delete library.properties#108

Open
edumeneses wants to merge 1 commit intomainfrom
107-remove-duplicated-libraryproperties
Open

delete library.properties#108
edumeneses wants to merge 1 commit intomainfrom
107-remove-duplicated-libraryproperties

Conversation

@edumeneses
Copy link
Member

Closes #107

Following the Puara/puara-gestures#59 (review), the actual library.properties lives on puara-arduino. The library.properties in this repo is redundant (and outdated).

Let's remove it.

@edumeneses edumeneses self-assigned this Mar 14, 2026
@edumeneses edumeneses linked an issue Mar 14, 2026 that may be closed by this pull request
@edumeneses
Copy link
Member Author

Ops, It seems we use the library.properties from this repo and simply copy it to puara-arduino. That means we should not edit the library.properties from the latter (which was manually edited to bump to version 1.0.1).

I'll leave this open to conclude this discussion, but it seems to me that neither this PR nor Puara/puara-gestures#59 (review) should be merged.

@cbicari
Copy link
Member

cbicari commented Mar 14, 2026

yeah, the puara module has the library.properties that we use in the CI afterwards.
for puara-getsures I'll have the CI create the file as it doesnt need to exist in puara-gesture, but does need to be in puara-gestures-arduino

@edumeneses
Copy link
Member Author

Are we doing the same for this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicated library.properties

2 participants