Replace dplyr::filter(DF, A & B) with dplyr::filter(DF, A, B)#291
Open
Replace dplyr::filter(DF, A & B) with dplyr::filter(DF, A, B)#291
dplyr::filter(DF, A & B) with dplyr::filter(DF, A, B)#291Conversation
Moohan
requested review from
a team,
CliveWG,
JosieSteele,
RyanDuffy01 and
cfraser2020
as code owners
Moohan
changed the title
dplyr::filter(DF, A & B) with dplyr::filter(DF, A, B)
Moohan
force-pushed
the
lint/filter
branch
3 times, most recently
from
e0f11c7 to
679f13e
Compare
`dplyr::filter(DF, A & B)` is the same as `dplyr::filter(DF, A, B)`, but the latter will be more readable / easier to format for long conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dplyr::filter(DF, A & B)is the same asdplyr::filter(DF, A, B), but the latter will be more readable / easier to format for long conditions.https://lintr.r-lib.org/reference/conjunct_test_linter.html#details