Skip to content

Byoc denodo path #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizihao-anu merged 2 commits into from
Feb 10, 2026
Merged

Byoc denodo path #1256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29bb4d6
fix absolute path of denodo output
lizihao-anu Feb 10, 2026
fc8ea36
denodo_output_path update
lizihao-anu Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/get_source_extract_path.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#' Denodo file output path
#' @export
denodo_output_path <- function() {
"sdl_byoc/byoc/output"
"/sdl_byoc/byoc/output"

Check warning on line 4 in R/get_source_extract_path.R

View workflow job for this annotation

GitHub Actions / lint-changed-files 

file=R/get_source_extract_path.R,line=4,col=3,[indentation_linter] Indentation should be 2 spaces but is 3 spaces.
}

#' Source Extract File Path
Expand Down Expand Up @@ -36,7 +36,7 @@
"pis",
"sds"
),
BYOC_MODE,

Check warning on line 39 in R/get_source_extract_path.R

View workflow job for this annotation

GitHub Actions / lint-changed-files 

file=R/get_source_extract_path.R,line=39,col=37,[object_name_linter] Variable and function name style should match snake_case or symbols.
...) {
if (year %in% type) {
cli::cli_abort("{.val {year}} was supplied to the {.arg year} argument.")
Expand Down Expand Up @@ -70,7 +70,7 @@
"outpatients" ~ "anon-outpatients_for_source",
"pis" ~ "anon-prescribing_file_for_source",
"sds" ~ "anon-sds-for-source"
) %>%

Check warning on line 73 in R/get_source_extract_path.R

View workflow job for this annotation

GitHub Actions / lint-changed-files 

file=R/get_source_extract_path.R,line=73,col=5,[pipe_consistency_linter] Use the |> pipe operator instead of the %>% pipe operator.
stringr::str_glue("-20{year}.parquet")

if (BYOC_MODE) {
Expand All @@ -87,5 +87,5 @@
)
}

return(source_extract_path)

Check warning on line 90 in R/get_source_extract_path.R

View workflow job for this annotation

GitHub Actions / lint-changed-files 

file=R/get_source_extract_path.R,line=90,col=3,[return_linter] Use implicit return behavior; explicit return() is not needed.
}
Loading