Conversation
mahesh0618
changed the title
zoltan-dulac
left a comment
zoltan-dulac
left a comment
There was a problem hiding this comment.
Let's discuss this in our next call -- I want to see how this works. It's demo time! :-)
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true |
There was a problem hiding this comment.
What happens when a developer tries to save a file and they don't have the prettier extension installed?
| @@ -1,2 +1,5 @@ | |||
| { | |||
| } No newline at end of file | |||
| "eslint.validate": ["json"], | |||
There was a problem hiding this comment.
What does this line do? Is it saying to only validate the json files? Because we'd want to validate more than just json.
| "dbaeumer.vscode-eslint", | ||
| "esbenp.prettier-vscode", | ||
| "firsttris.vscode-jest-runner", | ||
| "stylelint.vscode-stylelint", |
There was a problem hiding this comment.
I believe that stylelint is a completely separate package/dependency that we aren't using in this repo. Is this still an extension that we should be recommending?
We may also want to recommend bmewburn.vscode-intelephense-client to allow formatting and code intelligence for the PHP files.
| "trailingComma": "es5", | ||
| "tabWidth": 2, | ||
| "useTabs": true, | ||
| "overrides": [ |
There was a problem hiding this comment.
I believe that the package-lock.json is created using an indentation of 2 spaces by default. Do we want to add the package-lock.json file to .prettierignore file so that it doesn't override the default formatting?
|
@mahesh0618 , when you run |
3 participants
Includes following updates,