WIP: adding necessary changes to view as dark mode#127
WIP: adding necessary changes to view as dark mode#127basiabaldwin wants to merge 48 commits intomainfrom
Conversation
|
Just adding a note that after adding changes to .less rather than .css, dark mode change is appearing now for index! Will continue working on changes for rest of pages. |
…o go in a make sure all components change but this is a good start
basiabaldwin
changed the title
zoltan-dulac
left a comment
zoltan-dulac
left a comment
There was a problem hiding this comment.
Just a few things. Just to be clear: has the whole site been checked under dark mode? Let me know. If not, we should still have the title of this PR have a prefix of "WIP:"
basiabaldwin
changed the title
zoltan-dulac
left a comment
zoltan-dulac
left a comment
There was a problem hiding this comment.
Can you please look at the feedback here to ensure all the tasks are done?
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
basiabaldwin
left a comment
basiabaldwin
left a comment
There was a problem hiding this comment.
reviewed all changes and comments to ensure code is correct
zoltan-dulac
left a comment
zoltan-dulac
left a comment
There was a problem hiding this comment.
As mentioned on our last call, check all styling for contrast issues. I want to make sure the dark mode is as accessible as light mode.
That goes for text as well as graphical elements (e.g. box borders).
Signed-off-by: Basia Baldwin <35499120+basiabaldwin@users.noreply.github.com>
basiabaldwin
left a comment
basiabaldwin
left a comment
There was a problem hiding this comment.
reviewed awhile ago
|
Hi @zoltan-dulac , there is a change request on July 11 that I cannot dismiss and in turn it is blocking the merge. Wanted to see if it could be dismissed on your end. |
…e-a11y into dark-mode
…enable-a11y into dark-mode
4 participants
While the code I created does appear as dark mode (when these specific elements are changed in index.css), the code is not actually differentiating between light/dark mode (yet). Just doing this pull request so you can review how I did the changes. If you run the code currently, it will appear normally (light mode) but I attached screenshots of what the webpage looks like when the dark mode values would be used so you can compare it to the current webpage!