initial setup on thumbnail carousel with working example#198
initial setup on thumbnail carousel with working example#198ankitatechie wants to merge 4 commits intomainfrom
Conversation
initial setup on thumbnail carousel with working example
| <b>'node_modules/glider-js/glider.js', | ||
| 'node_modules/glider-js/glider.css',</b> | ||
| <b>'node_modules/@splidejs/splide/dist/js/splide.min.js', | ||
| 'node_modules/@splidejs/splide/dist/css/splide.min.css',</b> |
There was a problem hiding this comment.
These should not be bolded. The paragraph above states:
"For example, when I added the glider-js library to Enable so I can use it in the Carousel demos, I added the files I needed for the front-end to nodeFiles with these two lines:"
Technically, what you have worked on is not a general carousel. It's an image gallery. We should change this PR to not use the word carousel, but image gallery. I'll make appropriate comments to reflect what we should change.
|
|
||
| js/modules/enable-thumbnail-carousel.js: | ||
| 16: import '../node_modules/@splidejs/splide/dist/js/splide.min.js'; | ||
|
|
There was a problem hiding this comment.
I forgot this file exists. Please delete it. It is not needed anymore (all tickets are now in github Issues).
| @@ -0,0 +1,73 @@ | |||
| <section class="enable-thumbnail-carousel" aria-labelledby="thumbnail-carousel-heading"> | |||
There was a problem hiding this comment.
Let's call this page thumbnail-gallery.php
| <ul class="splide__list"> | ||
| <li class="splide__slide"> | ||
| <img src="images/carousel-example/00-turkish-spider-man.jpg" | ||
| alt="Bootleg versions of Spider-Man, Captain America and El Santo fighting." /> |
There was a problem hiding this comment.
For this example, I'd like to use product shots for something. I don't want to use the same images from another example.
There was a problem hiding this comment.
Change this image with the new images mentioned above.
| thumbnails.mount() | ||
| } | ||
|
|
||
| export default EnableThumbnailCarousel; |
There was a problem hiding this comment.
I am not sure where you'd change this, but I'd like to add the following changes:
- When the user tabs into the thumbnail, it reads "Go to slide ${n}". Can you change this to "Display slide ${n}"?
- When you click on a thumbnail, the aria-live region just reads the alt. Can you make it read "Now viewing: ${alt}".
2 participants
Initial setup of thumbnail carousel with a working example.
It includes the https://splidejs.com/ library as a npm package. I have already setup one working example along with a new page URL i.e. /thumbnail-carousel.php