Draft
Conversation
zoltan-dulac
reviewed
Mar 8, 2024
| ); | ||
| expect(maskedTelephone).toBe("123-456-781"); | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
These are great so far! Thank you.
I would also like to ensure we test the mouse functionality as well:
- Can we have a test that will click in the middle of a filled out masked input field? I want the test to be able to detect if the visual cursor and the input cursor match up.
- Another similar test to see if, when selecting a string in the middle of the input field, the visual selected and the input selected area match up.
- Checking what happens if invalid input occurs. e.g. letters in phone numbers.
Contributor
Author
There was a problem hiding this comment.
Copy, will work on getting these in.
Add automatic formatting 2
Apply automatic formatting to all files
Add README info about contributing and PRs
Conflicts: js/global.js
Adding npm publish information.
Use the automatically changed CSS file formatting
file_put_contents does not create a folder structure when invoked and need to call mkdir to get that taken care of.
Fixed #67: Needed to make folder for cache if not there.
…ifier/navigation.
Co-authored-by: Alison Hall <alisonh0101@gmail.com> Signed-off-by: AKSHAY PANCHAL <akshaypanchal67@gmail.com>
Co-authored-by: Alison Hall <alisonh0101@gmail.com> Signed-off-by: AKSHAY PANCHAL <akshaypanchal67@gmail.com>
Co-authored-by: Alison Hall <alisonh0101@gmail.com> Signed-off-by: AKSHAY PANCHAL <akshaypanchal67@gmail.com>
Co-authored-by: Alison Hall <alisonh0101@gmail.com> Signed-off-by: AKSHAY PANCHAL <akshaypanchal67@gmail.com>
Co-authored-by: Alison Hall <alisonh0101@gmail.com> Signed-off-by: AKSHAY PANCHAL <akshaypanchal67@gmail.com>
Add additional terms for components
…n readers to work.
[Issue# 49] - Enable Content Grammar / Spelling Issue Fix
…r-character-counter ENABLE-145 Unit Tests for Character Counter
…idget Signed-off-by: Jadan Ou <17204721+ocjadan@users.noreply.github.com>
…-pages Add table of contents to pages
feat: Added a new webpage for infographics
…-character-counter-widget Enable-8 create a better character counter widget
…e-a11y into masked-input-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following: