Skip to content

DTS-49841: fixed missing kpis benchmark #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunkambl merged 8 commits into from
Jan 20, 2026
Merged

DTS-49841: fixed missing kpis benchmark #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ecfed3
Merge branch 'develop' of https://github.com/PublicisSapient/knowhow-…
kunkambl Jan 11, 2026
8fe0326
Merge branch 'develop' of https://github.com/PublicisSapient/knowhow-…
kunkambl Jan 16, 2026
964af4c
DTS-49841: fixed missing kpis benchmark
kunkambl Jan 19, 2026
9260fc6
Merge branch 'develop' into DTS-49841_compute_benchmark_kpi_targets_kk
kunkambl Jan 19, 2026
8c904aa
Merge branch 'develop' into DTS-49841_compute_benchmark_kpi_targets_kk
kunkambl Jan 20, 2026
0551948
DTS-49841: fixed review comments
kunkambl Jan 20, 2026
d2ec454
Merge branch 'DTS-49841_compute_benchmark_kpi_targets_kk' of https://…
kunkambl Jan 20, 2026
7347cc9
DTS-49841: fixed review comments
kunkambl Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...om/publicissapient/kpidashboard/job/kpibenchmarkcalculation/parser/KpiParserStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ public KpiDataCountParser getParser(String kpiFilter) {
case "radiobutton_line", "radiobutton_grouped_column_plus_line" -> lineRadioFilterGraphParser;
case "multitypefilters_line", "multitypefilters_grouped_column_plus_line" ->
lineMultiFilterParser;
case "_cumulativemultilinechart" -> cumulativeMultilineChartParser;
case "_cumulativemultilinechart", "multiselectdropdown_cumulativemultilinechart" ->
cumulativeMultilineChartParser;
case "radiobutton_cumulativemultilinechart" -> cumulativeMultilineChartRadioButtonParser;
default -> lineGraphParser;
};
Expand Down
12 changes: 9 additions & 3 deletions ...ublicissapient/kpidashboard/job/kpibenchmarkcalculation/parser/LineFilterGraphParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,15 @@ public Map<String, List<Double>> getKpiDataPoints(List<?> kpiDataList) {
((List<DataCountGroup>) kpiDataList)
.stream()
.filter(
dataCountGroup ->
dataCountGroup.getFilter() != null
&& dataCountGroup.getFilter().equalsIgnoreCase("Overall"))
dataCountGroup -> {
if (dataCountGroup.getFilter() != null
&& (dataCountGroup.getFilter().equalsIgnoreCase("Overall")
|| dataCountGroup.getFilter().equalsIgnoreCase("Average Coverage")))
return true;
else
return dataCountGroup.getFilter2() != null
&& dataCountGroup.getFilter2().equalsIgnoreCase("Overall");
})
.map(DataCountGroup::getValue)
.findFirst();

Expand Down
23 changes: 16 additions & 7 deletions ...ient/kpidashboard/job/kpibenchmarkcalculation/service/KpiBenchmarkCalculationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ public KpiBenchmarkValues getKpiWiseBenchmarkValues(KpiDataDTO kpiDataDTO) {
* @param kpiDataDTO KPI data to fetch
* @return list of KPI elements from all projects
*/
private List<KpiElement> fetchKpiElements(KpiDataDTO kpiDataDTO) {
private synchronized List<KpiElement> fetchKpiElements(KpiDataDTO kpiDataDTO) {
return projectBasicConfigRepository
.findByKanbanAndProjectOnHold(kpiDataDTO.kanban(), false)
.stream()
.map(
config -> {
if (kpiDataDTO.kanban())
if (kpiDataDTO.kanban() || "Developer".equalsIgnoreCase(kpiDataDTO.kpiCategory()))
return constructKanbanKpiRequest(kpiDataDTO, config.getProjectNodeId());
else
return constructKpiRequest(kpiDataDTO, config.getProjectNodeId(), config.getId());
Expand All @@ -111,11 +111,15 @@ private List<KpiElement> fetchKpiElements(KpiDataDTO kpiDataDTO) {
.flatMap(
request -> {
try {
List<KpiElement> result;
if (kpiDataDTO.kanban())
return knowHOWClient.getKpiIntegrationValuesKanbanSync(request).stream();
else return knowHOWClient.getKpiIntegrationValuesSync(request).stream();
result = knowHOWClient.getKpiIntegrationValuesKanbanSync(request);
else result = knowHOWClient.getKpiIntegrationValuesSync(request);
return result != null ? result.stream() : java.util.stream.Stream.empty();
} catch (Exception ex) {
return null;
log.warn(
"Failed to fetch KPI data for KPI {}: {}", kpiDataDTO.kpiId(), ex.getMessage());
return java.util.stream.Stream.empty();
}
})
.toList();
Expand Down Expand Up @@ -146,16 +150,21 @@ private KpiBenchmarkValues createKpiBenchmarkValues(
Collectors.flatMapping(
entry -> entry.getValue().stream(), Collectors.toList())));

List<BenchmarkPercentiles> filterWiseBenchmark =
List<BenchmarkPercentiles> benchmarkByFilter =
allDataPoints.entrySet().stream()
.map(
entry ->
createBenchmarkPercentiles(entry.getValue(), entry.getKey(), isPositiveTrend))
.toList();

log.info(
"{} Generated Benchmark for KPI ID: {} with count {}",
JobConstants.LOG_PREFIX_KPI_BENCHMARK_CALCULATION,
kpiId,
benchmarkByFilter.size());
return KpiBenchmarkValues.builder()
.kpiId(kpiId)
.filterWiseBenchmarkValues(filterWiseBenchmark)
.filterWiseBenchmarkValues(benchmarkByFilter)
.calculationDate(Instant.now())
.build();
} catch (ClassCastException e) {
Expand Down