Bug fix/DTS-47410 broken connection notification for Processor tools#52
Merged
renukaprasaddk21 merged 4 commits intodevelopfrom Jul 1, 2025
Conversation
renukaprasaddk21
requested review from
Chittauri,
aksshriv1,
ananthpal,
manoj-srivastava and
vladinu
as code owners
Chittauri
approved these changes
Jul 1, 2025
vladinu
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Note:
Processor tools such as Jira, GitHub, GitLab, etc., rely on common library code to handle broken connection updates. I have implemented a fix that allows each processor to continue using the shared logic while supplying their own application-specific properties. This provides flexibility to:
Disable email notifications for individual processors if needed
Enable independent email handling per processor
This approach avoids anti-patterns by keeping shared logic centralized while allowing environment-specific configuration at the application level.