Fixes for multi-GPU #390
Open
Fixes for multi-GPU #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your LLMs made a mess of the main train file. Can you please submit a repro of the hang that this was supposed to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had GPT-5-codex fix a bunch of bugs in multi-gpu for me. Haven't reviewed what it did, but it fixed lots of console errors and a multi-GPU hang that locked up my runs.
time torchrun --standalone --nnodes=1 --nproc-per-node=2 -m pufferlib.pufferl train puffer_breakout
Tested on 3 machines:
Benchmark results (SPS): (1) 5090x2: 6M (2) Pro6000x2 (600W): 4M (3) Pro6000x4 (300W): 9M. Interesting that 5090 is faster than the much more expensive card. Could be the host CPU, which is a gamer 9950X3D vs 64-core Threadrippers.
Seems to be working. Hope this helps your dev