syscall, internal/routebsd: use hw.supported_arches on FreeBSD #19
+15
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading textual representation of the kernel config file to search for the "machine" config clause is awful, not to mention that kern.conftxt might be disabled at all. Use sysctl hw.supported_archs to detect 32bit binary running on amd64 host.
austinderek
force-pushed
the
master
branch
5 times, most recently
from
121e5bb to
7a1679d
Compare
|
🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact or requires further evaluation. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request. ⏱️ Latest scan covered changes up to commit 9a9c35b (latest) Check the status or cancel this secure code review here. |
austinderek
force-pushed
the
master
branch
23 times, most recently
from
7a1679d to
121e5bb
Compare
austinderek
force-pushed
the
master
branch
30 times, most recently
from
7bba745 to
37c78b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading textual representation of the kernel config file to search for
the "machine" config clause is awful, not to mention that kern.conftxt
might be disabled at all.
Use sysctl hw.supported_archs to detect 32bit binary running on amd64
host.
🔄 This is a mirror of upstream PR #73903