fix(cmd/go): prevent stale coverage data when using -coverpkg with test caching #5
+180
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinderek
force-pushed
the
master
branch
30 times, most recently
from
7a1679d to
121e5bb
Compare
austinderek
force-pushed
the
master
branch
20 times, most recently
from
4e182db to
d50240b
Compare
When using -coverpkg with coverage profiling, the coverage cache keys did not include the source file hashes of the covered packages. This could result in stale coverage reports that reference outdated line numbers when covered package sources were modified between test runs. This change adds a cached hash of the covered packages' source files that gets included in the coverage cache key computation. The hash is computed once per test execution using sync.Once to avoid redundant file system operations across multiple test packages. The fix ensures that coverage profiles are properly invalidated when any source file in the covered packages changes, preventing cache hits with stale line number references. Fixes golang#74873
austinderek
force-pushed
the
master
branch
2 times, most recently
from
b266318 to
d50240b
Compare
austinderek
force-pushed
the
fix/coverage-report-when-coverpkg-is-used
branch
from
e85b4c0 to
d8307ea
Compare
austinderek
force-pushed
the
master
branch
6 times, most recently
from
b266318 to
d50240b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes golang#23565 where cached coverage profiles with -coverpkg contained outdated line references when source files were modified but tests didn't directly depend on the changed packages.
🔄 This is a mirror of upstream PR #74773