net/http: reuse connection if entire unread body is in buffer #67
+74
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if an http response body is closed before fully read (fully means till EOF),
the underlying HTTP connection won't be reused. But in the current implementation,
body is first read into
bufio
buffer bybufio
reader, then from buffer by bodyReader
.So even if the body is closed before fully read, as long as the entire body has been
read into buffer, after discard buffer, the connection can be reused.
This will be useful when go client only read body if status is 200 while server sends
HTTP body in a non 200 status response.
🔄 This is a mirror of upstream PR golang#75303