-
Notifications
You must be signed in to change notification settings - Fork 13
Support for new status and forceclose server commands
#229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 32.09% 35.28% +3.18%
==========================================
Files 57 57
Lines 2673 2814 +141
==========================================
+ Hits 858 993 +135
- Misses 1815 1821 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
status and forceclose server commands
|
Logic seems solid to me at a first look. I'll try and actually run some stuff later today if I have some time. |
Adds a new
statusmessage for the socket server which sends back metadata about the server and active workers, to be shown via the plannedquarto call engine julia statuscommand.These commands are meant to work with this quarto-cli PR: quarto-dev/quarto-cli#11803
This PR changes the behavior of
run,closeandstopsuch that they error when they are used on files that are currently being run. Before, the command tasks would just wait until they could attain file locks, which in the case of a very long running or hung worker process could take forever. This PR adds theforceclosecommand to forcibly close a running file in those cases.Example
statusExample
forcecloseThis is currently exposed as
close --forcein the quarto-cli PR. First, normalclosethrows an error now:But force-closing works: