Security fixes #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2024 13:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across different files to enhance security, update dependencies, and clean up configuration. The most important changes are grouped by their themes below:
Security Enhancements:
src/Application/src/RazorPagesTestSample/Pages/Index.cshtml.cs: Added checks to ensure the destination directory exists and the file path is within the intended directory before extracting files. This prevents directory traversal attacks.Dependency Updates:
src/Application/tests/RazorPagesTestSample.Tests/RazorPagesTestSample.Tests.csproj: Updated theNewtonsoft.Jsonpackage from version11.0.2to13.0.3for improved performance and security.Configuration Changes:
.github/workflows/reusable-cd.yml: Updated the environment URL format for deployment.src/Application/src/RazorPagesTestSample/config.json: Removed unused configuration settings related to the Azure Container Registry.