Make TextDocumentManager.documentStore an associative array to speed up members such as TextDocumentManager.getOrFromFilesystem
#399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordlow
changed the title
TextDocumentManager.getOrFromFilesystemTextDocumentManager.getOrFromFilesystem
WebFreak001
reviewed
Aug 8, 2025
|
with the change in general if uri is changed in a document it will become inconsistent with the storage so maybe we should also restrict that member now |
|
What do you mean by restrict that member? Make it private and accessible behind a const property? Anyhow that's for another PR. |
…up members such as `TextDocumentManager.getOrFromFilesystem`
|
Ready again. |
|
Ping. |
nordlow
commented
Aug 8, 2025
|
Can you please merge, @WebFreak001? As |
|
Ping. Approval and merge, please? |
WebFreak001
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dub testpasses locally.