Conversation
This reverts commit 13d3406.
This was referenced Oct 29, 2025
ericwb
added a commit
to ericwb/bandit
that referenced
this pull request
Nov 10, 2025
This is a re-opening of PR PyCQA#1189 and revert of revert PyCQA#1217. PR PyCQA#1189 caused issue PyCQA#1216 which must be fixed as part of this PR. This change starts testing against Python 3.14 now that is has been officially released. Python 3.14 has dropped the deprecated use of ast.Bytes, ast.Ellipsis, ast.NameConstant, ast.Num, ast.Str. They are replaced with ast.Constant and Node.value is used to get the value instead of the previous attributes like Node.s. https://docs.python.org/3.14/whatsnew/3.14.html#id2 This also has the potential to break 3rd party plugins that were checking on Str or Num, etc. As a result, Bandit keeps the validity of checking on those non-existent ast types. These changes did break a quite a few plugins that were directly accessing ast classes to determine a result, but were fixed as part of this PR. Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
Merged
ericwb
added a commit
that referenced
this pull request
Nov 11, 2025
* Support of Python 3.14 This is a re-opening of PR #1189 and revert of revert #1217. PR #1189 caused issue #1216 which must be fixed as part of this PR. This change starts testing against Python 3.14 now that is has been officially released. Python 3.14 has dropped the deprecated use of ast.Bytes, ast.Ellipsis, ast.NameConstant, ast.Num, ast.Str. They are replaced with ast.Constant and Node.value is used to get the value instead of the previous attributes like Node.s. https://docs.python.org/3.14/whatsnew/3.14.html#id2 This also has the potential to break 3rd party plugins that were checking on Str or Num, etc. As a result, Bandit keeps the validity of checking on those non-existent ast types. These changes did break a quite a few plugins that were directly accessing ast classes to determine a result, but were fixed as part of this PR. Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Add 3.14 classifier Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Add test case Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Check if value.value is str Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Incorrect comment Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Fix up injection_sql.py Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * More checking on Constant.value Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> * Final Constant value checks Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com> --------- Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1189
Fixes #1216