Merged
Conversation
This makes it clearer that you don't need to use both virtualenv and venv at the same time
Flimm
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
lukehinds
reviewed
Jan 4, 2023
Member
lukehinds
left a comment
lukehinds
left a comment
There was a problem hiding this comment.
Could we swap this so the alternative is virtualenv. Reason being virtualenv needs installing first, where as the menv flag is native to python
ericwb
requested changes
Jan 12, 2025
ericwb
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it clearer that you don't need to use both virtualenv and venv at the same time