Refactor ignored name handling #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously constructed a frozen set of names that should be ignored at setup-time and then passed that set as an argument to each visitor function. A helper function -- _ignored(name, set) -- was used to test whether a given name should be ignored, matched using fnmatchcase(). This change introduces a `NameSet` type, which inherits from frozenset and implements `__contains__` using fnmatchcase(). This allows us to simply use the `in` operator in visitor functions. The previous code also (sometimes) treated the `ignores` argument as optional (defaulting to None). This value always exists so remove the optional notation.
Member
sigmavirus24
left a comment
sigmavirus24
left a comment
There was a problem hiding this comment.
No request for changes just a question otherwise LGTM
sigmavirus24
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously constructed a frozen set of names that should be ignored at setup-time and then passed that set as an argument to each visitor function. A helper function -- _ignored(name, set) -- was used to test whether a given name should be ignored, matched using fnmatchcase().
This change introduces a
NameSettype, which inherits from frozenset and implements__contains__using fnmatchcase(). This allows us to simply use theinoperator in visitor functions.The previous code also (sometimes) treated the
ignoresargument as optional (defaulting to None). This value always exists so remove the optional notation.