Fix time checks #100
Open
Fix time checks #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check if round_to_3_sig_figures produces a reasonable output. Pytest tests added.
Collaborator
|
@christopherwallis, there are conflicts on this really old PR now, and I believe @John2202W has done some work in this space. Between the two of you, can we decide if this PR should be closed or correct the conflicts? |
Collaborator
|
In PR 146 the user checks will have an extra argument to overwrite/disable the default formatting now. It'd be worth still adding in pytests for time comparisons |
Collaborator
|
@christopherwallis can make the necessary changes to this PR (I'm assuming just the tests for time checks based on @John2202W 's response) so that it can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to round_to_3_sig_figures function in fixate\ui_cmdline\cmd_line.py
Checks that output of conversion to 3 sig figs matches expected using math.isclose.
Pytests added in test_checks for testing the output formatting and confirming some other check functions.