Skip to content

Fix cases where the FTDI driver crashes test scripts preventing the power supply from being shut down #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cases where the FTDI driver crashes test scripts preventing the power supply from being shut down #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
540a343
Changed FTD2XXError to use `Exception` as a base rather than `BaseExc…
Sep 5, 2025
948f4d5
This is an optional continuance from 540a3432944d60d59ca02dc5ac845527…
Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/fixate/core/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
class SequenceAbort(BaseException):
class SequenceAbort(Exception):
Copy link
Collaborator

@clint-lawrence clint-lawrence Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are all getting touched, It's probably worth making a top level FixateError and deriving all the more specific errors from that.

pass


class ScriptError(BaseException):
class ScriptError(Exception):
pass


class TestRetryExceeded(BaseException):
class TestRetryExceeded(Exception):
Copy link
Collaborator

@clint-lawrence clint-lawrence Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it grows the scope of this PR too much, but generally python exceptions will be suffixed with Error. We could rename them, keeping an alias for compatibility (but probably not worth the churn)

pass


class TestAbort(BaseException):
class TestAbort(Exception):
pass


class InstrumentError(BaseException):
class InstrumentError(Exception):
pass


class InstrumentTimeOut(InstrumentError):
pass


class ParameterError(BaseException):
class ParameterError(Exception):
pass


class InvalidScalarQuantityError(BaseException):
class InvalidScalarQuantityError(Exception):
pass


Expand All @@ -38,29 +38,29 @@ class InstrumentNotConnected(InstrumentError):
pass


class NotCompatible(BaseException):
class NotCompatible(Exception):
pass


class MissingParameters(ParameterError):
pass


class UserInputError(BaseException):
class UserInputError(Exception):
pass


class TestClassError(BaseException):
class TestClassError(Exception):
pass


class TestError(BaseException):
class TestError(Exception):
pass


class DUTError(BaseException):
class DUTError(Exception):
pass


class CheckFail(BaseException):
class CheckFail(Exception):
pass
2 changes: 1 addition & 1 deletion src/fixate/drivers/ftdi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
}


class FTD2XXError(BaseException):
class FTD2XXError(Exception):
pass


Expand Down
Loading