Fix dottest dependency and use base_comm instead of MPI.COMM_WORLD #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrava87
approved these changes
May 30, 2025
There was a problem hiding this comment.
Hi @rohanbabbar04, thanks for these updates.
For the minor ones, I am totally fine; always good to fix things here and there that are incorrect 😄
Regarding MPI.COMM_WORLD vs self.base_comm I believe your changes are good in the light of the fact that we have now to comm inputs to DistributedArray. But I just want to check with @tharittk that he also agrees before merging this
|
@mrava87 I agree with the changes. Actually, those changes were suggested by @rohanbabbar04 in #130, but I was unaware of them (they slipped my mind), so I missed fixing those places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI.COMM_WORLDwithself.base_commdottestin__init__.py