Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7fcc2cf
Added impl, test and example
astroC86 Jun 2, 2025
6a9d382
Merge branch 'PyLops:main' into astroC86-SUMMA
astroC86 Jun 2, 2025
f72fce6
Addressed some comments
astroC86 Jun 10, 2025
c607283
Example formating
astroC86 Jun 10, 2025
de1a173
Rename MatrixMultiply file to MatrixMult
astroC86 Jun 10, 2025
82b7e34
Addressed more issues
astroC86 Jun 11, 2025
9e1a49f
Addressed comments
astroC86 Jun 13, 2025
22cde7b
Addressing changes
astroC86 Jun 13, 2025
740030d
Minor cosmetic changes
astroC86 Jun 13, 2025
a88dec3
More minor changes
astroC86 Jun 13, 2025
66f1770
Example shape dims general
astroC86 Jun 13, 2025
7ac593d
Added comments to example
astroC86 Jun 13, 2025
8a56096
I donot know why I thought I needed to batch
astroC86 Jun 13, 2025
42452a1
Inital docstring for matrix mult
astroC86 Jun 13, 2025
a110ff8
minor: cleanup of docstrings and updated example
mrava87 Jun 16, 2025
bd9ad37
minor: fix mistake in plot_matrixmult
mrava87 Jun 16, 2025
18db078
removed now useless bcast and fixed mask in test
astroC86 Jun 17, 2025
ef3c283
changed tests
astroC86 Jun 17, 2025
4e39068
Fixed tests and moved checks to root
astroC86 Jun 17, 2025
ed3b585
Fix internal check for MPIMatrixMult
astroC86 Jun 17, 2025
7b76f96
Fixed Notation
astroC86 Jun 17, 2025
3e9659e
Skipping test if number of procs is not square for now
astroC86 Jun 17, 2025
dd9b43c
Merge branch 'main' into astroC86-SUMMA
astroC86 Jun 18, 2025
a85e75a
Fixed Doc error
astroC86 Jun 26, 2025
b7e6702
Renamed layer and group as to row and col respectively
astroC86 Jun 27, 2025
ae5661b
minor: small improvements to text
mrava87 Jun 29, 2025
053e52d
minor: fix flake8
mrava87 Jun 29, 2025
9aedd7c
MatrixMul works with non-square prcs by creating square subcommunicator
astroC86 Jun 30, 2025
4c662d6
minor: stylistic fixes
mrava87 Jul 1, 2025
0c34b78
minor: fix flake8
mrava87 Jul 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/api/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Basic Operators
.. autosummary::
:toctree: generated/

MPIMatrixMult
MPIBlockDiag
MPIStackedBlockDiag
MPIVStack
Expand Down
223 changes: 223 additions & 0 deletions examples/plot_matrixmult.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,223 @@
r"""
Distributed Matrix Multiplication
=================================
This example shows how to use the :py:class:`pylops_mpi.basicoperators.MPIMatrixMult`
operator to perform matrix-matrix multiplication between a matrix :math:`\mathbf{A}`
blocked over rows (i.e., blocks of rows are stored over different ranks) and a
matrix :math:`\mathbf{X}` blocked over columns (i.e., blocks of columns are
stored over different ranks), with equal number of row and column blocks.
Similarly, the adjoint operation can be peformed with a matrix :math:`\mathbf{Y}`
blocked in the same fashion of matrix :math:`\mathbf{X}`.

Note that whilst the different blocks of the matrix :math:`\mathbf{A}` are directly
stored in the operator on different ranks, the matrix :math:`\mathbf{X}` is
effectively represented by a 1-D :py:class:`pylops_mpi.DistributedArray` where
the different blocks are flattened and stored on different ranks. Note that to
optimize communications, the ranks are organized in a 2D grid and some of the
row blocks of :math:`\mathbf{A}` and column blocks of :math:`\mathbf{X}` are
replicated across different ranks - see below for details.

"""

from matplotlib import pyplot as plt
import math
import numpy as np
from mpi4py import MPI

from pylops_mpi import DistributedArray, Partition
from pylops_mpi.basicoperators.MatrixMult import MPIMatrixMult

plt.close("all")

###############################################################################
# We set the seed such that all processes can create the input matrices filled
# with the same random number. In practical application, such matrices will be
# filled with data that is appropriate that is appropriate the use-case.
np.random.seed(42)

###############################################################################
# We are now ready to create the input matrices :math:`\mathbf{A}` of size
# :math:`M \times k` :math:`\mathbf{A}` of size and :math:`\mathbf{A}` of size
# :math:`K \times N`.
N, K, M = 4, 4, 4
A = np.random.rand(N * K).astype(dtype=np.float32).reshape(N, K)
X = np.random.rand(K * M).astype(dtype=np.float32).reshape(K, M)

################################################################################
# The processes are now arranged in a :math:`P' \times P'` grid,
# where :math:`P` is the total number of processes.
#
# We define
#
# .. math::
# P' = \bigl \lceil \sqrt{P} \bigr \rceil
#
# and the replication factor
#
# .. math::
# R = \bigl\lceil \tfrac{P}{P'} \bigr\rceil.
#
# Each process is therefore assigned a pair of coordinates
# :math:`(r,c)` within this grid:
#
# .. math::
# r = \left\lfloor \frac{\mathrm{rank}}{P'} \right\rfloor,
# \quad
# c = \mathrm{rank} \bmod P'.
#
# For example, when :math:`P = 4` we have :math:`P' = 2`, giving a 2×2 layout:
#
# .. raw:: html
#
# <div style="text-align: center; font-family: monospace; white-space: pre;">
# ┌────────────┬────────────┐
# │ Rank 0 │ Rank 1 │
# │ (r=0, c=0) │ (r=0, c=1) │
# ├────────────┼────────────┤
# │ Rank 2 │ Rank 3 │
# │ (r=1, c=0) │ (r=1, c=1) │
# └────────────┴────────────┘
# </div>
#
# This is obtained by invoking the
# `:func:pylops_mpi.MPIMatrixMult.active_grid_comm` method, which is also
# responsible to identify any rank that should be deactivated (if the number
# of rows of the operator or columns of the input/output matrices are smaller
# than the row or columm ranks.

base_comm = MPI.COMM_WORLD
comm, rank, row_id, col_id, is_active = MPIMatrixMult.active_grid_comm(base_comm, N, M)
print(f"Process {base_comm.Get_rank()} is {"active" if is_active else "inactive"}")
if not is_active: exit(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in real-life problem this would not fly as we usually don't want to use operators in isolation but combine them... so this way I suspect some ranks will be killed and if used by other operators the overall run will crash.

I am not so concerned as in practice we will hardly end up in these edge cases, so now if someone does for just MatrixMult things will still work, which is nice... if they do it for more complex operators that include MatrixMult, they will have to handle it...

Copy link
Contributor Author

@astroC86 astroC86 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get rid of the exit if you want, it shouldn't affect anything since all operations from then on would use the new communicator that includes only the active procs in the newly defined square grid and so other procs are free to do what they want, or just remain idle. In theory we can come up with an example where:

base_comm = MPI.COMM_WORLD
comm, ......= MPIMatrixMult.active_grid_comm(base_comm, N, M)
....
## matrix mul here would use the new comm `comm`
.....
# all procs have to reach this barrier before proceeding to perform the second op
base_comm.barrier() 
## second op here
....

Copy link
Contributor

@mrava87 mrava87 Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you get my point here.. in PyLops-MPI we do not really care to apply two operators one after the other, this is not the purpose of the library; what we want/need is to be able to chain/stack atomic operators (like MatrixMult) to create more scientifically interesting ones and solve inverse problems. So what I really want to be able to do is something like:

Aop = MPIMatrixMult(A_p, M, base_comm=comm, dtype=dtype_str)
...

Dop = FirstDerivative(dims=(N, col_end_X - col_start_X), axis=0, dtype=np.float32)
DBop = MPIBlockDiag(ops=[Dop, ], base_comm=comm, mask=cols_id)
Op = DBop @ Aop
y1_dist = Op @ x_dist

I added this to the test and check consistency with the serial version and everything seems to work (at least for the case with all rank active)

This was an oversight from my side, I should have asked to check / checked that we could do it before merging... not too bad, we can tests and examples now - will try tonight to open a PR with what I have so far

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ook, I see your concern! That is weird I will investigate


# Create sub‐communicators
p_prime = math.isqrt(comm.Get_size())
row_comm = comm.Split(color=row_id, key=col_id) # all procs in same row
col_comm = comm.Split(color=col_id, key=row_id) # all procs in same col

################################################################################
# At this point we divide the rows and columns of :math:`\mathbf{A}` and
# :math:`\mathbf{X}`, respectively, such that each rank ends up with:
#
# - :math:`A_{p} \in \mathbb{R}^{\text{my_own_rows}\times K}`
# - :math:`X_{p} \in \mathbb{R}^{K\times \text{my_own_cols}}`
#
# .. raw:: html
#
# <div style="text-align: left; font-family: monospace; white-space: pre;">
# <b>Matrix A (4 x 4):</b>
# ┌─────────────────┐
# │ a11 a12 a13 a14 │ <- Rows 0–1 (Process Grid Row 0)
# │ a21 a22 a23 a24 │
# ├─────────────────┤
# │ a41 a42 a43 a44 │ <- Rows 2–3 (Process Grid Row 1)
# │ a51 a52 a53 a54 │
# └─────────────────┘
# </div>
#
# .. raw:: html
#
# <div style="text-align: left; font-family: monospace; white-space: pre;">
# <b>Matrix X (4 x 4):</b>
# ┌─────────┬─────────┐
# │ b11 b12 │ b13 b14 │ <- Cols 0–1 (Process Grid Col 0), Cols 2–3 (Process Grid Col 1)
# │ b21 b22 │ b23 b24 │
# │ b31 b32 │ b33 b34 │
# │ b41 b42 │ b43 b44 │
# └─────────┴─────────┘
# </div>
#

blk_rows = int(math.ceil(N / p_prime))
blk_cols = int(math.ceil(M / p_prime))

rs = col_id * blk_rows
re = min(N, rs + blk_rows)
my_own_rows = max(0, re - rs)

cs = row_id * blk_cols
ce = min(M, cs + blk_cols)
my_own_cols = max(0, ce - cs)

A_p, X_p = A[rs:re, :].copy(), X[:, cs:ce].copy()

################################################################################
# We are now ready to create the :py:class:`pylops_mpi.basicoperators.MPIMatrixMult`
# operator and the input matrix :math:`\mathbf{X}`
Aop = MPIMatrixMult(A_p, M, base_comm=comm, dtype="float32")

col_lens = comm.allgather(my_own_cols)
total_cols = np.sum(col_lens)
x = DistributedArray(global_shape=K * total_cols,
local_shapes=[K * col_len for col_len in col_lens],
partition=Partition.SCATTER,
mask=[i % p_prime for i in range(comm.Get_size())],
base_comm=comm,
dtype="float32")
x[:] = X_p.flatten()

################################################################################
# We can now apply the forward pass :math:`\mathbf{y} = \mathbf{Ax}` (which effectively
# implements a distributed matrix-matrix multiplication :math:`Y = \mathbf{AX}`)
# Note :math:`\mathbf{Y}` is distributed in the same way as the input
# :math:`\mathbf{X}`.
y = Aop @ x

###############################################################################
# Next we apply the adjoint pass :math:`\mathbf{x}_{adj} = \mathbf{A}^H \mathbf{x}`
# (which effectively implements a distributed matrix-matrix multiplication
# :math:`\mathbf{X}_{adj} = \mathbf{A}^H \mathbf{X}`). Note that
# :math:`\mathbf{X}_{adj}` is again distributed in the same way as the input
# :math:`\mathbf{X}`.
xadj = Aop.H @ y

###############################################################################
# To conclude we verify our result against the equivalent serial version of
# the operation by gathering the resulting matrices in rank0 and reorganizing
# the returned 1D-arrays into 2D-arrays.

# Local benchmarks
y = y.asarray(masked=True)
col_counts = [min(blk_cols, M - j * blk_cols) for j in range(p_prime)]
y_blocks = []
offset = 0
for cnt in col_counts:
block_size = N * cnt
y_block = y[offset: offset + block_size]
if len(y_block) != 0:
y_blocks.append(
y_block.reshape(N, cnt)
)
offset += block_size
y = np.hstack(y_blocks)

xadj = xadj.asarray(masked=True)
xadj_blocks = []
offset = 0
for cnt in col_counts:
block_size = K * cnt
xadj_blk = xadj[offset: offset + block_size]
if len(xadj_blk) != 0:
xadj_blocks.append(
xadj_blk.reshape(K, cnt)
)
offset += block_size
xadj = np.hstack(xadj_blocks)

if rank == 0:
y_loc = (A @ X).squeeze()
xadj_loc = (A.T.dot(y_loc.conj())).conj().squeeze()

if not np.allclose(y, y_loc, rtol=1e-6):
print("FORWARD VERIFICATION FAILED")
print(f'distributed: {y}')
print(f'expected: {y_loc}')
else:
print("FORWARD VERIFICATION PASSED")

if not np.allclose(xadj, xadj_loc, rtol=1e-6):
print("ADJOINT VERIFICATION FAILED")
print(f'distributed: {xadj}')
print(f'expected: {xadj_loc}')
else:
print("ADJOINT VERIFICATION PASSED")
Loading