Skip to content

fix send/recv bug in CuPy + MPI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix send/recv bug in CuPy + MPI #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pylops_mpi/DistributedArray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ def _send(self, send_buf, dest, count=None, tag=None):
count = send_buf.size
nccl_send(self.base_comm_nccl, send_buf, dest, count)
else:
self.base_comm.Send(send_buf, dest, tag)
self.base_comm.send(send_buf, dest, tag)

def _recv(self, recv_buf=None, source=0, count=None, tag=None):
""" Receive operation
Expand All @@ -543,11 +543,8 @@ def _recv(self, recv_buf=None, source=0, count=None, tag=None):
else:
raise ValueError("Using recv with NCCL must also supply receiver buffer ")
else:
# MPI allows a receiver buffer to be optional
if recv_buf is None:
return self.base_comm.recv(source=source, tag=tag)
self.base_comm.Recv(buf=recv_buf, source=source, tag=tag)
return recv_buf
# MPI allows a receiver buffer to be optional and receives as a Python Object
return self.base_comm.recv(source=source, tag=tag)

def _nccl_local_shapes(self, masked: bool):
"""Get the the list of shapes of every GPU in the communicator
Expand Down