-
Notifications
You must be signed in to change notification settings - Fork 5
test: fix tests not working with high nranks and change GA to test that #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rohanbabbar04 no idea why the note that without the proposed changes some of the tests failed for N=9 for me locally... most are tests I added with the PS: in my local conda env, I used |
|
Hmm, let me give it a look |
@rohanbabbar04 did you manage to have some time to take a look at this? |
Oops, I missed this one. I will look at it during the weekend to find out why it is happening, and let you know |
ece7324 to
12d1708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a minor change to the OpenMPI execution by using ^openib to exclude InfiniBand, since GitHub Actions runners may stall/show error messages when running with higher ranks. I think we should add it since it will be required as well.
I will now merge this 🙂
|
Great, thanks a lot @rohanbabbar04 for investigating this 😀 |

This PR fixes a number issues that arose when trying to increase the number of ranks in the test suite to 9 or 16.
As a consquence, I have also decided to modify the GA
buildto run tests with 2,4,9 ranks instead of 2,3,4