test: started adding tests for nccl utility routines #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to add tests for various
ncclutility routines inpylops_mpi.utils._ncclfor primitive communication calls.The need for this tests stems from the realization that if we pass
send_bufof different size tonccl_allgatherwe get a deadlock... so we should make sure to check and raise an error before this happens.Note that the last test is currently commented out because mpiexec will hang if running this test - I believe this is due to the fact that
nccl_comm.allGatherdoes not cope withsend_bufof different size between ranks