Skip to content

Commit d7130c5

Browse files
authored
Merge pull request #342 from mrava87/migrreadme
Minor: small improvements to MIGRATION_V1_V2 file
2 parents 2b88c08 + 677cf4d commit d7130c5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

MIGRATION_V1_V2.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ This file is intended to guide users willing to convert their codes from PyLops
55
In the following we provide a detailed description of all the breaking changes introduced in v2, which
66
should be used as a checklist when converting a piece of code using PyLops from v1 to v2.
77

8-
- Several operators have deprecated `N` as a keyword. To migrate, pass only `dims` if both `N` and `dims` are currently being passed.
9-
If only `N` is being passed, ensure it is being passed as a value and not a keyword argument (e.g., change `Flip(N=100)` to `Flip(100)`).
10-
- `utils.dottest`: The relative tolerance is new set via `rtol` (before `tol`), and absolute tolerance is new supported via the keyword `atol`. When calling it with purely positional arguments, note that after `rtol` comes now first `atol` before `complexflag`. When using `raiseerror=True` it now emits an `AttributeError` instead of a `ValueError`.
8+
- Several operators have deprecated `N` as a keyword. To migrate, pass only `dims` if both `N` and `dims` are currently
9+
being passed. If only `N` is being passed, ensure it is being passed as a value and not a keyword argument (e.g.,
10+
change `Flip(N=100)` to `Flip(100)`).
11+
- `utils.dottest`: Change `tol` into `rtol`. Absolute tolerance is now also supported via the keyword `atol`.
12+
When calling it with purely positional arguments, note that after `rtol` comes now first `atol` before `complexflag`.
13+
When using `raiseerror=True` it now emits an `AttributeError` instead of a `ValueError`.

0 commit comments

Comments
 (0)