Skip to content

ci: fix msrv job #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024
Merged

ci: fix msrv job #13

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a527016
ci: fix msrv job
davidhewitt Oct 25, 2024
fc7a19a
ci: bump jobs to use 3.13 by default
davidhewitt Oct 25, 2024
773c60b
use tomllib
davidhewitt Oct 25, 2024
bf924f3
just use `cargo add` to set MSRV versions
davidhewitt Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.10"
python-version: "3.13"
- run: pip install black==24.10.0
- uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -47,15 +47,7 @@ jobs:
fail-fast: false # If one platform fails, allow the rest to keep testing.
matrix:
rust: [stable]
python-version:
[
"3.9",
"3.10",
"3.11",
"3.12",
"3.13",
"pypy-3.9",
]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy-3.9"]
platform:
[
{
Expand Down Expand Up @@ -86,7 +78,7 @@ jobs:
include:
# Test minimal supported Rust version
- rust: 1.63.0
python-version: "3.10"
python-version: "3.13"
platform:
{
os: "ubuntu-latest",
Expand Down Expand Up @@ -122,27 +114,28 @@ jobs:
toolchain: ${{ matrix.rust }}
target: ${{ matrix.platform.rust-target }}

# - if: matrix.platform.os == 'ubuntu-latest'
# name: Prepare LD_LIBRARY_PATH (Ubuntu only)
# run: echo LD_LIBRARY_PATH=${pythonLocation}/lib >> $GIHUB_ENV
- if: ${{ matrix.msrv == 'MSRV' }}
name: Set MSRV dependencies
run: |
cargo add tokio@=1.38.1

- name: Build (no features)
run: cargo build --no-default-features --verbose --target ${{ matrix.platform.rust-target }}

- name: Build
run: cargo build --features=${{env.features}} --verbose --target ${{ matrix.platform.rust-target }}

# uvloop doesn't compile under Windows, Python 3.11-dev, and PyPy
- if: ${{ matrix.platform.os != 'windows-latest' && matrix.python-version != '3.11-dev' && !startsWith(matrix.python-version, 'pypy') }}
# uvloop doesn't compile under Windows and PyPy
- if: ${{ matrix.platform.os != 'windows-latest' && !startsWith(matrix.python-version, 'pypy') }}
name: Install pyo3-asyncio test dependencies
run: |
python -m pip install -U uvloop

- if: ${{ matrix.msrv != 'MSRV' && matrix.python-version != '3.11-dev' && !startsWith(matrix.python-version, 'pypy') }}
- if: ${{ matrix.msrv != 'MSRV' && !startsWith(matrix.python-version, 'pypy') }}
name: Test
run: cargo test --all-features --target ${{ matrix.platform.rust-target }}

- if: ${{ matrix.msrv == 'MSRV' && matrix.python-version != '3.11-dev' && !startsWith(matrix.python-version, 'pypy') }}
- if: ${{ matrix.msrv == 'MSRV' && !startsWith(matrix.python-version, 'pypy') }}
name: Test (MSRV, --no-default-features)
run: cargo test --no-default-features --features tokio-runtime,async-std-runtime,attributes,unstable-streams --target ${{ matrix.platform.rust-target }}

Expand Down
Loading