Check for awaitable instead of coroutine in stream glue #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The into_stream glue code provides backpressure on the wrapped async generator when its internal buffer is full. This is done by returning a future that resolves after the buffer flushes and the item sent. But a future is not a coroutine so the
iscoroutinecheck currently used always returnsFalseand the future is neverawaited. This causes the generator to continue to be pulled non-stop until completion, at which point the glue'stxwill be closed even though there are still pending sends, causing them to be missed.The correct check is
isawaitableto detectasyncio.Future.