map io::ErrorKind::IsADirectory/NotADirectory to Python on 1.83+
#4747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
reviewed
Nov 29, 2024
Contributor
Tpt
left a comment
Tpt
left a comment
There was a problem hiding this comment.
Thank you for pushing this!
It would be great to add the conversion in the other direction in line 28 and a test in line 169 (both of src/err/impls.rs)
Contributor
Author
|
Thanks for pointing that out, not sure why I stopped with only half the work done 🙃 |
Contributor
|
Thank you for this MR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maps
io::ErrorKind::IsADirectory/NotADirectoryto the corresponding Python exception when compiling on Rust 1.83+.Closes #4740