release: 0.24.2 #5043
Merged
release: 0.24.2 #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use std::ptr::eq where relevant * allow(clippy::ptr_eq) in pyo3-ffi * Add ref for allow(clippy::large_enum_variant)
* ci: change default Python version to 3.13 * fix FFI definition for `PyCodeObject`
* Update noxfile.py * Update pull_request_template.md
* add * add * remove components, not used * use nox to publish * Update 5027.packaging.md * no newsfragment needed for ci change * add release environment --------- Co-authored-by: David Hewitt <[email protected]>
* Update building-and-distribution.md Fix typo * Update guide/src/building-and-distribution.md
* Unraw complex struct enum field python names Stray case related to #2395 (probably unnoticed because the functionality is newer and a bit of an edge case). The `python_name` of struct-type enum variant fields (and the `__match_args__` of the variant) do not unraw the names of these fields, which effectively makes them unusable as the resulting identifiers contain '#' which the Python lexer interprets as comments. The only reason you'd probably want to do this anyway is to use reserved identifiers (`type` in my case). * Add newsfragment for fix * Fix clippy lints in impl_complex_enum_variant_match_args and callers No need to pass mutable vec ref anymore * don't overeagerly collect field_names iterator * add test case for complex enums containing raw identifiers * only test raw ident pattern matching on Python 3.10+
Member
Author
|
I think this is ready to go, will put live on Sunday evening unless I hear reason to delay. |
Member
Author
|
#5065 (comment) may delay this |
Member
Author
|
All good, #5069 demonstrates this is not an issue in the PyO3 library, just the test suite. |
Contributor
|
Is it possible to add the bigdecimal feature to this release as well or would that be in a future release? |
Member
Author
|
Sorry for the long delay here. Family commitments again left me no time to push this. I will update the release date now and seek to push this tonight.
As this is a patch release I will not pick that feature to here; we will release 0.25 in the not too distant future and ship the feature then. |
davidhewitt
force-pushed
the
release-0.24.2
branch
from
70664c6 to
1ff782b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding branch for cherry picks for the 0.24.2 release.