Conversation
|
There are compiler errors in |
|
Update: This is the command that fails in the pipeline from what I can tell: Running this locally, doesn't fail for me....and as I type this, I see the pipeline is running against py 3.14, so maybe I'm running against a different version of python. |
|
The 3.14 failures are known and not caused by this PR, sorry for the confusion. I'll retry the 3.13 job, looks like possible flakiness |
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, just a couple small tidy ups I saw.
| #[repr(C)] | ||
| #[cfg(not(any(PyPy, GraalPy, Py_3_11)))] | ||
| pub struct PyFrameObject { |
There was a problem hiding this comment.
We should add a 5154.removed.md to note that we no longer offer access to the frame object internal structure on versions before 3.11.
| // TODO: Created this file as part of fixing pyframe.rs and cpython/pyframe.rs | ||
| // TODO: Finish defining or moving declarations now in Include/pytypedefs.h |
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
|
@davidhewitt back to you |
3 participants
Add pyframe declarations and move around declarations to match CPython as of this PR (3.13, I think?).