Drop const_concat! macro and str-focused const combine functions #5315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
commented
Aug 13, 2025
| /// `out` should be a buffer at the correct size of `combined_len(pieces)`, else this will panic. | ||
| #[cfg(mut_ref_in_const_fn)] // requires MSRV 1.83 | ||
| #[allow(clippy::incompatible_msrv)] // `split_at_mut` also requires MSRV 1.83 | ||
| pub const fn combine_bytes(pieces: &[&[u8]], mut out: &mut [u8]) { |
Contributor
Author
There was a problem hiding this comment.
I don't think we need combine to be pub
davidhewitt
approved these changes
Aug 13, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, a welcome tidy up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use the bytes-based functions now
Follow up to #5286