Skip to content

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Aug 24, 2025

I just noticed a that two small problems that slipped through #5289

  • I forgot to revert the deprecations on Py::downcast_bound(_unchecked) (add Bound::cast and friends #5289 (comment))
  • The new Py::cast_bound(_unchecked) methods should be on Py<T> and not Py<PyAny> (to be consistent with Bound)

Xref #5249

@Icxolu Icxolu added this to the 0.26 milestone Aug 24, 2025
@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Aug 24, 2025
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks 👍

@davidhewitt davidhewitt added this pull request to the merge queue Aug 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2025
@davidhewitt
Copy link
Member

Needs #5362 to fix the merge failure, sorry.

@davidhewitt davidhewitt disabled auto-merge August 24, 2025 18:34
@davidhewitt davidhewitt added this pull request to the merge queue Aug 24, 2025
Merged via the queue into PyO3:main with commit a0c7d2c Aug 24, 2025
43 of 44 checks passed
@Icxolu Icxolu deleted the cast-bound branch August 25, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants