-
Notifications
You must be signed in to change notification settings - Fork 886
Allow naive datetime into chrono DateTime<Local>
conversion
#5507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tnx for continuing the work! |
@Icxolu are you happy with this given your alternative suggestion in #5507 (comment) ? |
I'm not at my keyboard this week, so i just skimmed through it. I'm fine with the change and I agree that my suggestion is probably a much bigger performance hit than this. I just think than in general we should try to minimize such specializations because it makes it harder to follow how the extraction works and harder to maintain if too many special methods crop up. |
Completely agree with this, I was sad to add a second special case to |
This is a rebuild of #5178 which uses a private helper in
FromPyObject
to perform the specialized conversion.