move PyTypeInfo::NAME and ::MODULE into #[pyclass] machinery
#5579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
approved these changes
Nov 3, 2025
Contributor
Tpt
left a comment
Tpt
left a comment
There was a problem hiding this comment.
Thank you! Having MODULE as a private implementation things make a lot of sense. It's a footgun in its current state.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5352
The idea is that
PyTypeInfo::NAMEis a constant value which we've historically populated incorrectly for native types anyway. Also Python is a dynamic language, let's just encourage users to get that state at runtime.PyTypeInfo::MODULEis even worse, it is really only useful for the#[pyclass]machinery and is not populated consistently (or at all in many cases).This PR deprecates those two constants, and:
PyClass::NAMEconstant for the name which is given to the#[pyclass]by the machinery. I think it's fine for this to be public as it seems obvious how it should work.PyClassImpl, as I think that might change in the future anyway.