Skip to content

replace memoffset with std::mem::offset_of! in pyo3-ffi-check #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidhewitt merged 1 commit into from
Nov 11, 2025
Merged

replace memoffset with std::mem::offset_of! in pyo3-ffi-check #5615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyo3-ffi-check/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ publish = false

[dependencies]
pyo3-ffi-check-macro = { path = "./macro" }
memoffset = "0.9.0"

[dependencies.pyo3-ffi]
path = "../pyo3-ffi"
Expand Down
4 changes: 2 additions & 2 deletions pyo3-ffi-check/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ fn main() {
($struct_name:ident, $field:ident, $bindgen_field:ident) => {{
// some struct fields are deprecated but still present in the ABI
#[allow(clippy::used_underscore_binding, deprecated)]
let pyo3_ffi_offset = memoffset::offset_of!(pyo3_ffi::$struct_name, $field);
let pyo3_ffi_offset = std::mem::offset_of!(pyo3_ffi::$struct_name, $field);
#[allow(clippy::used_underscore_binding)]
let bindgen_offset = memoffset::offset_of!(bindings::$struct_name, $bindgen_field);
let bindgen_offset = std::mem::offset_of!(bindings::$struct_name, $bindgen_field);

if pyo3_ffi_offset != bindgen_offset {
failed = true;
Expand Down
Loading