Avoid introducing generic parameter with implied bounds from an associated type relation #5638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iated type relation
davidhewitt
changed the title
davidhewitt
changed the title
bschoenmaeckers
approved these changes
Nov 21, 2025
Member
bschoenmaeckers
left a comment
bschoenmaeckers
left a comment
There was a problem hiding this comment.
Looks cleaner indeed 👍
davidhewitt
added a commit
that referenced
this pull request
Nov 23, 2025
…iated type relation (#5638) * avoid introducing generic parameter with implied bounds from an associated type relation * newsfragment
davidhewitt
added a commit
that referenced
this pull request
Nov 23, 2025
…iated type relation (#5638) * avoid introducing generic parameter with implied bounds from an associated type relation * newsfragment
Merged
davidhewitt
added a commit
that referenced
this pull request
Nov 30, 2025
…iated type relation (#5638) * avoid introducing generic parameter with implied bounds from an associated type relation * newsfragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly modified version of the patch suggested rust-lang/rust#149081 (comment)
There is a Rust compiler bug currently on beta which causes it to crash compiling PyO3. The bug seems to be related to implied bounds on a generic parameter introduced by the bounds being added via an associated type constraint.
In this PR, where possible instead of adding implied bounds I've instead removed the generic parameter and referred to it via the associated type. This seems slightly cleaner anyway, in my opinion.
This probably is worth shipping in PyO3 0.27.2