Introspection: add TYPE_HINT to PyTypeInfo manual implementations #5641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
force-pushed
the
tpt/type-info-hint
branch
from
4c65f64 to
d8018d7
Compare
davidhewitt
approved these changes
Nov 26, 2025
Comment on lines
+34
to
+35
| #[cfg(feature = "experimental-inspect")] | ||
| const TYPE_HINT: TypeHint = TypeHint::module_attr("types", "EllipsisType"); |
Member
There was a problem hiding this comment.
I had to double-check whether this and NotImplemented should be special-cased like None.
My conclusion (from the typing spec, and mypy playground) is that they should not be special cased and the code here is correct 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.