add #[cold] paths for unlikely error-fetching branches
#5657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
approved these changes
Nov 29, 2025
Tpt
reviewed
Nov 29, 2025
src/err/mod.rs
Outdated
| fn failed_to_fetch() -> PyErr { | ||
| const FAILED_TO_FETCH: &str = "attempted to fetch exception but none was set"; | ||
|
|
||
| #[cfg(debug_assertions)] |
Contributor
There was a problem hiding this comment.
Hyper-nit: might be slightly more readable with a if cfg!:
if cfg!(debug_assertions) {
panic!("{}", FAILED_TO_FETCH)
} else {
crate::exceptions::PySystemError::new_err(FAILED_TO_FETCH)
}
Member
Author
There was a problem hiding this comment.
I like it, good idea 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries out a small cleanup I noted while reading the error implementation recently.
The error handling code had logic to handle panics and missing exceptions inline in the functions. I pull this all out into separate
#[cold]functions so that the happy paths are as lean as possible.