Introspection: fix return type hint for Result<()>#5674
Merged
davidhewitt merged 5 commits intoPyO3:mainfrom Dec 12, 2025
Merged
Introspection: fix return type hint for Result<()>#5674davidhewitt merged 5 commits intoPyO3:mainfrom
davidhewitt merged 5 commits intoPyO3:mainfrom
Conversation
Tpt
force-pushed
the
tpt/inspect-none-tuple
branch
from
5d42a68 to
63af1e4
Compare
davidhewitt
reviewed
Dec 5, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, generally looks great! Couple of small comments.
Xref #4896
src/impl_/introspection.rs
Outdated
Comment on lines
26
to
30
| pub const fn is_empty_tuple_from_closure<B: IsEmptyTuple>( | ||
| _closure_returning_bool: &impl FnOnce() -> B, | ||
| ) -> bool { | ||
| B::VALUE | ||
| } |
Member
There was a problem hiding this comment.
This is neat, it provides a way to lift type inference into compile time 🎉
davidhewitt
reviewed
Dec 5, 2025
davidhewitt
reviewed
Dec 12, 2025
Uses a hack to get const specialization working Closes PyO3#5645
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Tpt
force-pushed
the
tpt/inspect-none-tuple
branch
from
e9eb750 to
bcf82df
Compare
davidhewitt
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a hack to get const specialization working
Closes #5645