Skip to content

Fix noxfile for python 3.7/3.8#5911

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
bschoenmaeckers:fix-ci-noxfile
Mar 25, 2026
Merged

Fix noxfile for python 3.7/3.8#5911
davidhewitt merged 1 commit intoPyO3:mainfrom
bschoenmaeckers:fix-ci-noxfile

Conversation

@bschoenmaeckers
Copy link
Member

Not sure how this sneaked through.

xref #5898

@bschoenmaeckers bschoenmaeckers added CI-build-full CI-skip-changelog Skip checking changelog entry labels Mar 25, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2026

Merging this PR will degrade performance by 16.19%

❌ 1 regressed benchmark
✅ 104 untouched benchmarks
⏩ 1 skipped benchmark1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
drop_many_objects 14.7 µs 17.5 µs -16.19%

Comparing bschoenmaeckers:fix-ci-noxfile (5fd449d) with main (e8566a9)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@Tpt
Copy link
Contributor

Tpt commented Mar 25, 2026

It seems we need to gate pyrefly on 3.8+ in pytests/pyproject.toml. sorry for that

@davidhewitt
Copy link
Member

We can just merge #5912 to "fix" 3.7.

The 3.7 / 3.8 test suites don't block merge, a slight kindness to external contributors to not have to deal with ancient Python versions.

@davidhewitt davidhewitt enabled auto-merge March 25, 2026 13:11
@davidhewitt davidhewitt added this pull request to the merge queue Mar 25, 2026
Merged via the queue into PyO3:main with commit 603a69a Mar 25, 2026
165 of 176 checks passed
@bschoenmaeckers
Copy link
Member Author

Great to see the emscripten failure solve itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-build-full CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants