-
Notifications
You must be signed in to change notification settings - Fork 69
Refactor code quality #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code quality #231
Conversation
|
This looks very nice. Let us know when it is ready for review. |
|
Hey @lkstrp, I'm submitting this PR focused on code quality improvements, which should help streamline our ongoing development work. There will be additional PRs coming in the next few weeks, but I wanted to prioritize this one first. As we discussed previously, I've postponed the doc-string enhancements for a later phase. Would appreciate your review when you have the opportunity! |
|
That's perfect, thanks a lot @cgaete! |
|
|
||
| makedirs(join(package_config["data_dir"], "data", "in"), exist_ok=True) | ||
| makedirs(join(package_config["data_dir"], "data", "out"), exist_ok=True) | ||
| makedirs(join(str(package_config["data_dir"]), "data", "in"), exist_ok=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change for this PR, but just the note that we wanna move to pathlib in general. Not sure if mypy would be happy without the str cast then
Changes proposed in this Pull Request
.github/workflows/type-checking.ymlworkflow to run mypy static type checking on the codebaseAdditional improvements:
@euronion @FabianHofmann
Checklist
doc.doc/release_notes.rstof the upcoming release is included.