Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches the model from using the internal “KN2045_Bal_v4” settings to the public “KN2045_Mix” configuration. Key changes include updating the run parameter across multiple scripts, renaming scenarios and references in configuration files, and adjusting logging formats for improved readability.
Reviewed Changes
Copilot reviewed 25 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/pypsa-de/modify_existing_heating.py | Updated run parameter and reformatted log message |
| scripts/pypsa-de/modify_district_heat_share.py | Changed run parameter from “KN2045_Bal_v4” to “KN2045_Mix” |
| scripts/pypsa-de/modify_cost_data.py | Updated run parameter |
| scripts/pypsa-de/cluster_wasserstoff_kernnetz.py | Updated run parameter |
| scripts/pypsa-de/build_scenarios.py | Modified aviation demand logic and adjusted steel share updates |
| scripts/pypsa-de/build_mobility_demand.py | Added year parameter in transport data retrieval |
| ... | Other scripts and configuration files updated consistently |
Files not reviewed (4)
- Snakefile: Language not supported
- config/config.public.yaml: Language not supported
- config/scenarios.public.yaml: Language not supported
- config/scenarios.template.yaml: Language not supported
Comments suppressed due to low confidence (2)
config/config.de.yaml:31
- Changing the database name from 'ariadne2_intern' to 'ariadne2' should be coordinated with the actual public database configuration. Ensure that connection credentials and access rights are updated accordingly.
db_name: ariadne2
scripts/pypsa-de/build_scenarios.py:18
- Removing the try/except block and retrieving aviation demand in TWh/yr assumes that the key always exists in the dataframe. Please verify that all databases used in production provide this key to avoid potential key errors.
aviation = df.loc["Final Energy|Bunkers|Aviation", "TWh/yr"]
|
@JulianGeis I was not able to reproduce the large discrepancies you were seeing when comparing master to this PR. However, I found a unintended change in the steel consumption that had lead to small ~1% changes in e.g. coal demand. It's fixed now and i get: |


This will abolish the distinction between public and private workflows. Some caveats:
The 2020 input values of the models are not published in the DB, therefore they are hard-coded into the respective scripts
All units in the exporter and the plots are changed from GJ/PJ to MWh/TWh
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title