Update DEA technology data for energy storage #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage temperatures for tes and change gas storage to order_data and delete add_gas_storage, since the format of xlsx version 9 changed for gas storage
… storage charger/discharger
for more information, see https://pre-commit.ci
…omKae00/technology-data into update_DEA_energy_storage_data
amos-schledorn
requested changes
Apr 23, 2025
for more information, see https://pre-commit.ci
…omKae00/technology-data into update_DEA_energy_storage_data
Contributor
Author
|
@amos-schledorn Thanks for the review! I merged the master and re-ran Snakemake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Updated DEA Energy Storage data file (technology_data_catalogue_for_energy_storage.xlsx) to the newest version 9 – costs are now given in 2020 currency year.
Added storage temperatures as a parameter for central and decentral water tanks as well as for pit thermal energy storage.
Integrated gas storage processing directly into the order_data function and removed the add_gas_storage function, as its data structure now matches that of the other components in the technology_data_catalogue_for_energy_storage.xlsx file.
Added manual_cost_year_assignments_2020 for components created later from the available data and thus not covered by cost_year_2020 (e.g. gas storage charger/discharger).
As mentioned in issue Investment cost of underground natural gas storage too low by a factor of ~7 #154, the specific investment cost for gas storage increases by a factor of 7 with the new DEA data. We now use the directly stated specific investment cost for the storage creation and calculate the specific cost of the charger and discharger as done previously. What's your opinion on that @fneum ?
Wrong unit conversion for FOM for pit thermal energy storage in the current DEA technology_data_for_energy_storage file as of 09 April, 2025. Reported values are 1,000 times too high. See issue: Incorrect FOM Unit Conversion in DEA technology catalogue v9 for Pit Thermal Energy Storage #203
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.