Test readme #676
Open
Test readme #676
+149
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
requested changes
Nov 15, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Not sure what this is doing except adding >>> in front of code?
I do not see why we should do that.
Plus, you seem to be reformatting code so some lines do not fit on the screen anymore.
Maybe also let's not do this?
Plus my usual comments:
- please write a descriptive summary of your PR, I have a hard time understanding what you want to do here. Use AI if you need to, some description is better than none.
- where possible, do different things in separate PR, e.g., adding output coercion to
portfolio_performanceis not "test readme"
Contributor
Author
|
No, try to provoke the test with faulty code in README.md |
Collaborator
|
?? I am sorry, I genuinely have no idea what you are referring to. Can you please add a description to the PR and explain its purpose? There should be no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.